Conversation
change: when creating private key is to NOT provide a rand.Reader, and allow ed25519.GenerateKey() decide what reader to use, this enables and fixes #67
Member
|
Looks like tests failed. |
Pull Request Test Coverage Report for Build 12020805601Details
💛 - Coveralls |
derekcollison
left a comment
Member
There was a problem hiding this comment.
Still have check failures below.
Member
Member
Author
|
that was the first commit - tooling on ci old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change: from "golang.org/x/crypto/ed25519" to "crypto/ed25519"
change: when creating private key is to NOT provide a rand.Reader, and allow ed25519.GenerateKey() decide what reader to use, this enables and fixes #67
Other changes suggested by #67 change the structure of the library in more aggressive ways - currently, the private key is encoded into its NATS seed format in
kp. Storing the private key, and prefix instead to enable extracting and formatting the seed, etc, means that all the size and format checks would have to cascade to various APIs.