test: fix sign sandbox tests #1678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f4699c to
7a8fc95
Compare
7a8fc95 to
5e349ea
Compare
gilcu3
previously approved these changes
Dec 17, 2025
Contributor
gilcu3
left a comment
There was a problem hiding this comment.
Thank you! Left only minor fixes and a couple of questions
pbeza
previously approved these changes
Dec 17, 2025
Contributor
Author
good point. I added some info to that issue |
pbeza
approved these changes
Dec 17, 2025
netrome
approved these changes
Dec 17, 2025
Collaborator
netrome
left a comment
There was a problem hiding this comment.
Quick skimming, thanks for doing this!
| .await | ||
| .unwrap(); | ||
| let status_2 = req.sign_ensure_included(&alice, &contract).await?; | ||
| // unfortunately, we still can't completely get rid of this sleep |
Collaborator
|
Setting this to merge as @kevindeforth is on vacation tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1666
main improvements:
follow-ups: