Skip to content

chore(contract): sandbox code organization #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevindeforth merged 2 commits into from
Dec 18, 2025
Merged

chore(contract): sandbox code organization #1683

kevindeforth merged 2 commits into from
Dec 18, 2025

Conversation

@kevindeforth
Copy link
Contributor

@kevindeforth kevindeforth commented Dec 17, 2025 •
edited
Loading

resolves #1685

@kevindeforth kevindeforth force-pushed the kd/1666-fix-sandbox-sign-test branch from 7f4699c to 7a8fc95 Compare December 17, 2025 12:09
@kevindeforth kevindeforth mentioned this pull request Dec 17, 2025
Merged
@kevindeforth kevindeforth force-pushed the kd/1666-fix-sandbox-sign-test branch from 7a8fc95 to 5e349ea Compare December 17, 2025 12:11
@kevindeforth kevindeforth changed the title test(contract): code org chore(contract): code org Dec 17, 2025
@kevindeforth kevindeforth changed the title chore(contract): code org chore(contract): sandbox code organization Dec 17, 2025
@kevindeforth kevindeforth force-pushed the kd/1657-sandbox-code-org branch from c1d8d8c to 0d06bbc Compare December 17, 2025 14:16
@kevindeforth kevindeforth marked this pull request as ready for review December 17, 2025 14:53
@kevindeforth kevindeforth force-pushed the kd/1657-sandbox-code-org branch from 0d06bbc to b152047 Compare December 17, 2025 17:15
Base automatically changed from kd/1666-fix-sandbox-sign-test to main December 17, 2025 20:59
@kevindeforth kevindeforth force-pushed the kd/1657-sandbox-code-org branch from b152047 to 516bc88 Compare December 17, 2025 21:56
DSharifi
DSharifi previously approved these changes Dec 18, 2025
View reviewed changes
gilcu3
gilcu3 previously approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@gilcu3 gilcu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Commented on three renaming TODOs that I think were meant to be handled here. We could easily take care of that and get it merged, what do you think @netrome ?

@kevindeforth kevindeforth dismissed stale reviews from gilcu3 and DSharifi via a054e59 December 18, 2025 10:35
@kevindeforth kevindeforth force-pushed the kd/1657-sandbox-code-org branch from a054e59 to 6127111 Compare December 18, 2025 10:37
@kevindeforth kevindeforth added this pull request to the merge queue Dec 18, 2025
Merged via the queue into main with commit 10e04fd Dec 18, 2025
14 checks passed
@kevindeforth kevindeforth deleted the kd/1657-sandbox-code-org branch December 18, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gilcu3 gilcu3 gilcu3 approved these changes

@DSharifi DSharifi DSharifi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

split common.rs

4 participants

@kevindeforth @gilcu3 @DSharifi