Modify JupyterHub networkPolicy to match existing policy - #1991
Merged
Merged
Conversation
Member
Author
|
@costrouc do you see any reason why we shouldn't disabled the |
Member
Author
|
@pavithraes @kcpevey could you please review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
What does this implement/fix?
Fixes #1965
Having the CHP networkPolicy enabled for JupyterHub deployed to AWS, Azure and GCP was no trouble so I'm not sure why this only seems to affect Digital Ocean. We also have the networkPolicy disabled for
hubandsingleuseralready.We should definitely test this change on the other clouds before merging - I don't expect this to cause problems since removing the network policy makes internal networking more permissible.
Put a
xin the boxes that applyTesting
Any other comments?