ENH: specify required fields when retrieving available gcp projects - #2008
Merged
Merged
Conversation
iameskild
approved these changes
Sep 13, 2023
iameskild
left a comment
Member
There was a problem hiding this comment.
I had one small question but otherwise, LGTM.
| output = subprocess.check_output(["gcloud", "projects", "list", "--format=json"]) | ||
| data = json.loads(output.decode("utf-8")) | ||
| output = subprocess.check_output( | ||
| ["gcloud", "projects", "list", "--format=json(name,projectId)"] |
Member
There was a problem hiding this comment.
I needed to add quotes like this: --format="json(name, projectId)". I believe this is due to a difference between MacOS and Linux. Is this something you can confirm @fangchenli?
Contributor
Author
There was a problem hiding this comment.
I needed to add quotes like this:
--format="json(name, projectId)". I believe this is due to a difference between MacOS and Linux. Is this something you can confirm @fangchenli?
Yes, quotes are required when running it in terminal on Linux. But when calling from python, "--format=json(name,projectId)" works on both MacOS and Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
What does this implement/fix?
Put a
xin the boxes that applyTesting
Any other comments?