fix general node scaling bug for azure - #2517
Merged
Merged
Conversation
viniciusdc
approved these changes
Jun 18, 2024
viniciusdc
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for catching it @Adam-D-Lewis
Contributor
|
Also, it's pretty interesting to discover that the order of our default node groups in our configuration matters. |
Member
Author
Oh yeah, I hope that's not the case. I hope we're making sure we pass in the general node group first to terraform at least regardless of it's order in nebari-config.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Fixes #2516
What does this implement/fix?
Put a
xin the boxes that applyTesting
Any other comments?