Skip to content

Pass oauth_no_confirm=True to jhub-apps - #2631

Merged
aktech merged 1 commit into
nebari-dev:developfrom
krassowski:jhub-apps-oauth_no_confirm
Aug 19, 2024
Merged

aktech merged 1 commit into
nebari-dev:developfrom
krassowski:jhub-apps-oauth_no_confirm

Conversation

@krassowski

@krassowski krassowski commented Aug 14, 2024

Copy link
Copy Markdown
Member

Reference Issues or PRs

What does this implement/fix?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Nope

@krassowski
krassowski marked this pull request as ready for review August 16, 2024 11:49
@krassowski

krassowski commented Aug 16, 2024

Copy link
Copy Markdown
Member Author

Tested locally with a new user, works fine 馃帀

For reference tested with:

default_images:
  jupyterhub: quay.io/nebari/nebari-jupyterhub:krassowski-jhub-apps-branch-aac2e51-20240816

@aktech aktech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @krassowski

@aktech
aktech merged commit 57f6de6 into nebari-dev:develop Aug 19, 2024
@krassowski
krassowski deleted the jhub-apps-oauth_no_confirm branch August 19, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Do not show oauth screen for users accessing the main jhub-apps service

2 participants