feat: add metrics service - #2199
Merged
bors[bot] merged 1 commit intoAug 12, 2020
Merged
Conversation
chaoticlonghair
force-pushed
the
pr/add-metrics-service
branch
2 times, most recently
from
July 30, 2020 19:07
168a666 to
7a298fc
Compare
This was referenced Jul 30, 2020
chaoticlonghair
force-pushed
the
pr/add-metrics-service
branch
from
July 31, 2020 06:11
7a298fc to
4501400
Compare
quake
previously approved these changes
Aug 3, 2020
keroro520
suggested changes
Aug 3, 2020
chaoticlonghair
force-pushed
the
pr/add-metrics-service
branch
from
August 3, 2020 17:25
4501400 to
10888e7
Compare
Contributor
Author
|
The last "force-pushed" just removed a useless comment. |
keroro520
previously approved these changes
Aug 4, 2020
doitian
suggested changes
Aug 5, 2020
Contributor
|
Since it heavily depends on a 3rd-party crate, please and link and some introductions in the PR description. |
doitian
reviewed
Aug 5, 2020
Contributor
Author
|
Hold for updating, according to review suggestions. |
Contributor
|
@yangby-cryptape Ready to unhold? |
doitian
previously approved these changes
Aug 11, 2020
Contributor
Author
Everything is ready! And I have been using the commits in my laptop. |
bors Bot
added a commit
that referenced
this pull request
Aug 11, 2020
2220: refactor: split logger config and service r=TheWaWaR,doitian,keroro520 a=yangby-cryptape _Originally posted by @doitian in #2199 (comment) - Split logger config and service. - Let `ckb-app-config` only be dependent on `ckb-logger-config`. - Move the function which checks identifier into `ckb-util`. Co-authored-by: Boyu Yang <yangby@cryptape.com>
chaoticlonghair
dismissed stale reviews from doitian and keroro520
via
August 12, 2020 01:55
0db57da
chaoticlonghair
force-pushed
the
pr/add-metrics-service
branch
from
August 12, 2020 01:55
10888e7 to
0db57da
Compare
Contributor
Author
|
Updated according to review suggestions. The most major change is: create a config crate so that app config does not depend on services. |
chaoticlonghair
force-pushed
the
pr/add-metrics-service
branch
from
August 12, 2020 04:22
0db57da to
42ff9ea
Compare
Contributor
Author
|
@quake I updated the format of dependencies' versions in |
quake
approved these changes
Aug 12, 2020
keroro520
approved these changes
Aug 12, 2020
Contributor
Author
|
bors r=quake,keroro520 |
Contributor
|
Build succeeded:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/nervosnetwork/ckb/blob/0db57dafaad73efbfcf5330ec289efba94fd6975/util/metrics-service/src/lib.rs#L35-L37
https://github.com/nervosnetwork/ckb/blob/0db57dafaad73efbfcf5330ec289efba94fd6975/util/metrics-config/src/lib.rs#L5-L22