Repository navigation
Use precompiled RISC-V test artifacts - #542
Conversation
Security reviewResult: 1 confirmed finding (Low) Reviewed range: Review model: FindingAll 141 instruction-named Please regenerate the architecture fixtures from reviewed source and add reproducible provenance plus structural checks that reject empty test spans, unexpected duplicate hashes, and missing instruction-specific expectations. Validation
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Replaces generated RISC-V test binaries with precompiled artifacts and simplifies test machine construction.
Changes:
- Adds architecture, cryptography, and specification artifact coverage.
- Consolidates interpreter and assembly helpers.
- Updates tests with explicit VM versions, ISAs, and arguments.
| File | Description |
|---|---|
tests/test_signal_pause.rs |
Updates pause tests. |
tests/test_resume.rs |
Updates snapshot test setup. |
tests/test_mop.rs |
Updates MOP test configurations. |
tests/test_b_extension.rs |
Updates bit-extension tests. |
tests/test_artifact.rs |
Runs precompiled artifact suites. |
tests/test_a_extension.rs |
Updates atomic-extension tests. |
tests/machine_build.rs |
Provides generic interpreter and assembly builders. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Replace generated RISC-V test binaries with precompiled artifacts covering architecture, cryptography, and specification tests. Simplify machine_build by consolidating multiple version- and ISA-specific helpers into generic asm and int functions, and update affected tests to pass the required VM version, ISA, and arguments explicitly.