Skip to content

Bump version for 2.5.2 reelase#567

Merged
jfy133 merged 2 commits into
devfrom
bump-version-for-reelase
Feb 2, 2024
Merged

Bump version for 2.5.2 reelase#567
jfy133 merged 2 commits into
devfrom
bump-version-for-reelase

Conversation

@jfy133

@jfy133 jfy133 commented Feb 2, 2024

Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 changed the base branch from master to dev February 2, 2024 08:11
@github-actions

github-actions Bot commented Feb 2, 2024

Copy link
Copy Markdown

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @jfy133,

It looks like this pull-request is has been made against the nf-core/mag master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/mag dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions

github-actions Bot commented Feb 2, 2024 •
edited
Loading

Copy link
Copy Markdown

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 409b7f8

+| ✅ 210 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   5 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.5.2
  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file [TODO: try and test using for --host_fasta and --host_genome]
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowMag.groovy: Optionally add in-text citation tools to this list.
  • schema_lint - Input mimetype is missing or empty

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.12.1
  • Run at 2024-02-02 08:13:41

@jfy133 jfy133 merged commit 7b75454 into dev Feb 2, 2024
@jfy133 jfy133 deleted the bump-version-for-reelase branch February 2, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mashehu mashehu mashehu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jfy133 @mashehu