Skip to content

Release PR: 4.0.0#807

Merged
jfy133 merged 165 commits into
mainfrom
dev
May 22, 2025
Merged

Release PR: 4.0.0#807
jfy133 merged 165 commits into
mainfrom
dev

Conversation

@jfy133

@jfy133 jfy133 commented May 14, 2025

Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133

jfy133 commented May 14, 2025

Copy link
Copy Markdown
Member Author

@nf-core-bot fix linting

@github-actions

github-actions Bot commented May 14, 2025

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 81d9ff5

+| ✅ 334 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗  48 tests had warnings |!
Details

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.2.1
  • Run at 2025-05-22 10:10:56

@github-actions

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2ed16ce

+| ✅ 334 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗  48 tests had warnings |!
Details

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.2.1
  • Run at 2025-05-14 08:55:11

@jfy133 jfy133 marked this pull request as ready for review May 14, 2025 11:59
Comment thread nextflow.config Outdated
Comment thread README.md Outdated
Comment thread CHANGELOG.md Outdated
@jfy133

jfy133 commented May 14, 2025

Copy link
Copy Markdown
Member Author

@nf-core-bot fix linting

@charles-plessy charles-plessy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I only had a minor question on comma addition…

Comment thread conf/test.config

@erikrikarddaniel erikrikarddaniel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with two small comments.

Comment thread docs/usage.md Outdated
## A note on GTDB having too many files or using too many inodes

The GTDB is very large both in size and by the number of files it contains.
The uncompressed database requires >200k inodes, which can be problematic for users with limited storage resources.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is perhaps "files" better than "inodes" here? Easier to understand for the less technically savvy even if slightly less correct. Also below.

Comment thread docs/usage.md Outdated
Co-authored-by: Daniel Lundin <erik.rikard.daniel@gmail.com>
Comment thread docs/usage.md Outdated
Comment thread docs/usage.md Outdated
Comment thread CHANGELOG.md Outdated
@jfy133 jfy133 merged commit 7ffd8b8 into main May 22, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants