Skip to content

linting: fix incorrect unqoting of val() version numbers#4042

Merged
mashehu merged 8 commits into
nf-core:devfrom
mashehu:fix-val-quotes-in-meta-yml
Feb 12, 2026
Merged

linting: fix incorrect unqoting of val() version numbers#4042
mashehu merged 8 commits into
nf-core:devfrom
mashehu:fix-val-quotes-in-meta-yml

Conversation

@mashehu

@mashehu mashehu commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@mashehu mashehu requested a review from a team February 12, 2026 11:22
@codecov

codecov Bot commented Feb 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.40%. Comparing base (77e43b4) to head (5f8f7da).
⚠️ Report is 1 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread nf_core/modules/lint/meta_yml.py Outdated
Comment thread nf_core/utils.py Outdated

@mirpedrol mirpedrol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mashehu mashehu force-pushed the fix-val-quotes-in-meta-yml branch from c43d39c to bc5e5cf Compare February 12, 2026 13:04
@mashehu mashehu force-pushed the fix-val-quotes-in-meta-yml branch from bc5e5cf to 91c8bc2 Compare February 12, 2026 14:05
@mashehu mashehu merged commit 942cf3a into nf-core:dev Feb 12, 2026
114 checks passed
mashehu added a commit to mashehu/tools that referenced this pull request Mar 25, 2026
)

* improve debug logging

* make sure to not unqote val entries, to avoid number-string confusion

* add test

* [automated] Update CHANGELOG.md

* Update nf_core/modules/lint/meta_yml.py

Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>

* removed unneeded try except

* update uv deps

* pin setuptools to <81 to support refgenie

---------

Co-authored-by: nf-core-bot <core@nf-co.re>
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants