Skip to content

fix(lint): use correct config key zenodo_doi#4201

Merged
mashehu merged 3 commits into
nf-core:devfrom
MasterOfFeelingFish:clawoss/fix/zenodo-release-config-key
Apr 27, 2026
Merged

fix(lint): use correct config key zenodo_doi#4201
mashehu merged 3 commits into
nf-core:devfrom
MasterOfFeelingFish:clawoss/fix/zenodo-release-config-key

Conversation

@MasterOfFeelingFish

@MasterOfFeelingFish MasterOfFeelingFish commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

The readme lint test checks for "zenodo_doi" in the ignore config, but the documented config key in the docstring and docs is "zenodo_release". This means adding zenodo_release to the .nf-core.yml ignore list has no effect — the warning still appears.

Changed the key in the code to match the documentation.

Fixes #3398

@github-actions

github-actions Bot commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

This PR is against the main branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @MasterOfFeelingFish,

It looks like this pull-request is has been made against the MasterOfFeelingFish/tools main branch.
The main branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to main are only allowed if they come from the MasterOfFeelingFish/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@MasterOfFeelingFish MasterOfFeelingFish changed the base branch from main to dev April 18, 2026 04:44
@MasterOfFeelingFish MasterOfFeelingFish force-pushed the clawoss/fix/zenodo-release-config-key branch from 3191e52 to ff1bb63 Compare April 19, 2026 03:31
mashehu
mashehu requested changes Apr 20, 2026
View reviewed changes

@mashehu mashehu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

I think zenodo_doi makes more sense than zenodo_release so could you please fix it the other way around? 🙂

@mashehu mashehu force-pushed the clawoss/fix/zenodo-release-config-key branch from a4e5b93 to e90ae65 Compare April 27, 2026 09:09
@mashehu mashehu changed the title fix(lint): use correct config key zenodo_release instead of zenodo_doi fix(lint): use correct config key zenodo_doi Apr 27, 2026
@mashehu

mashehu commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

@nf-core-bot changelog

@mashehu mashehu enabled auto-merge (squash) April 27, 2026 12:05
@codecov

codecov Bot commented Apr 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.34%. Comparing base (adad48c) to head (be65a6c).
⚠️ Report is 13 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu mashehu merged commit a79b66f into nf-core:dev Apr 27, 2026
118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mashehu mashehu mashehu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

adding zenodo_release to nf-core.yml does still produce a warning

3 participants

@MasterOfFeelingFish @mashehu @nf-core-bot