Skip to content

Clarify execution context of nf-core modules test command - #4346

Merged
mashehu merged 2 commits into
devfrom
clarify-execution-context
Jun 24, 2026
Merged

Clarify execution context of nf-core modules test command#4346
mashehu merged 2 commits into
devfrom
clarify-execution-context

Conversation

@jfy133

@jfy133 jfy133 commented Jun 24, 2026

Copy link
Copy Markdown
Member

Addresses this report: https://nfcore.slack.com/archives/C09H9L3R614/p1766044507625309

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.45%. Comparing base (c36e2a5) to head (a23ead1).

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jfy133

jfy133 commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

@nf-core-bot changelog

@github-actions

Copy link
Copy Markdown
Contributor

Deployment Triggered 🚀

jfy133, started a branch deployment to production (branch: clarify-execution-context)

You can watch the progress here 🔗

Details
{
  "type": "branch",
  "environment": {
    "name": "production",
    "url": null
  },
  "deployment": {
    "timestamp": "2026-06-24T10:21:06.444Z",
    "logs": "https://github.com/nf-core/tools/actions/runs/28091733223"
  },
  "git": {
    "branch": "clarify-execution-context",
    "commit": "a23ead1ac82ba10be1724814653e80817b955cdb",
    "verified": false,
    "committer": "jfy133",
    "html_url": "https://github.com/nf-core/tools/commit/a23ead1ac82ba10be1724814653e80817b955cdb"
  },
  "context": {
    "actor": "jfy133",
    "noop": false,
    "fork": false,
    "comment": {
      "created_at": "2026-06-24T10:20:53Z",
      "updated_at": "2026-06-24T10:20:53Z",
      "body": "@nf-core-bot changelog",
      "html_url": "https://github.com/nf-core/tools/pull/4346#issuecomment-4788232632"
    }
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

@github-actions

Copy link
Copy Markdown
Contributor

Deployment Results ✅

jfy133 successfully deployed branch clarify-execution-context to production

Details
{
  "status": "success",
  "environment": {
    "name": "production",
    "url": null
  },
  "deployment": {
    "id": 5179416306,
    "timestamp": "2026-06-24T10:21:24.242Z",
    "logs": "https://github.com/nf-core/tools/actions/runs/28091733223",
    "duration": 18
  },
  "git": {
    "branch": "clarify-execution-context",
    "commit": "a23ead1ac82ba10be1724814653e80817b955cdb",
    "verified": false
  },
  "context": {
    "actor": "jfy133",
    "noop": false,
    "fork": false
  },
  "reviews": {
    "count": 1,
    "decision": "APPROVED"
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

@jfy133
jfy133 enabled auto-merge June 24, 2026 10:21
@mashehu
mashehu disabled auto-merge June 24, 2026 10:22
@mashehu
mashehu merged commit 0a0a1dc into dev Jun 24, 2026
1 check passed
@mashehu
mashehu deleted the clarify-execution-context branch June 24, 2026 10:22
@mashehu

mashehu commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

no ci running, so no automerge. need to force merge atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants