Add CI tests to test running a pipeline when it's created from a template#2334
Merged
Conversation
…ate skipping different areas
mashehu
reviewed
Jun 21, 2023
Member
Author
Can do both, I just found it more organized in a different file |
Codecov Report
@@ Coverage Diff @@
## dev #2334 +/- ##
=======================================
Coverage 73.08% 73.08%
=======================================
Files 78 78
Lines 8779 8784 +5
=======================================
+ Hits 6416 6420 +4
- Misses 2363 2364 +1
|
Member
Author
|
Actually, because these pipelines created from a template are unbranded, the pipeline prefix is different, so I think it's easier to have two separate files |
mashehu
reviewed
Jun 22, 2023
mashehu
left a comment
Contributor
There was a problem hiding this comment.
should also only run if the pipeline template was actually changed:
on:
push:
paths:
- nf_core/pipeline-template/**
Member
Author
|
Everything working now! 🥳 |
mashehu
approved these changes
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test to see if it's viable to add CI tests for all possible templates:
➕ We could also add the same for linting.
⚠️ It will take considerably more time and Github runners, so needs to be discussed before merging.
👁️ This will make sure that bugs as the ones found recently (#2332 and #2333) are not repeated.
PR checklist
CHANGELOG.mdis updateddocsis updated