streamline use of logged and natural R - #424
Merged
Merged
Conversation
seabbs
approved these changes
Jun 19, 2025
seabbs
left a comment
Contributor
There was a problem hiding this comment.
Yes looks good. We have some angry linting.
Contributor
|
Check failures are my fault and will be dealt with in #388 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #324
closes #321
now consistently arguments passed to and returned by functions are on the natural scale
The only difference of substance to before is in the prior distributions for R - from checking this does not lead to any problems. However it did unearth a typo in the script for generating forecasts. With profound apologies I am including a fix in the PR in spite of being unrelated to its core mission.