Deduplicate default suite attributes in preferSwiftTesting - #2699
Merged
Merged
Conversation
Co-authored-by: calda <1811727+calda@users.noreply.github.com>
Copilot
AI
changed the title
Fix duplicate default suite attributes in preferSwiftTesting
Deduplicate default suite attributes in Sep 21, 2026
preferSwiftTesting
Copilot created this pull request from a session on behalf of
calda
September 21, 2026 21:08
View session
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2699 +/- ##
===========================================
+ Coverage 95.44% 95.45% +0.01%
===========================================
Files 182 182
Lines 27933 27936 +3
===========================================
+ Hits 26660 26666 +6
+ Misses 1273 1270 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preferSwiftTestingwas appending--default-test-suite-attributeseven when a suite already declared the same attribute, producing duplicate annotations (e.g. two@MainActorlines). This change makes attribute insertion idempotent for existing suite-level attributes.Rule behavior update
defaultTestSuiteAttributesagainst attributes already present on the XCTest suite declaration before insertion.Regression coverage
@MainActorwhiledefaultTestSuiteAttributes: ["@MainActor"]is set.@MainActoron the converted Swift Testing suite.