feat(presets): add platformatic preset - #4554
p-dubovitsky wants to merge 1 commit into
Conversation
|
@p-dubovitsky is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe PR adds a Platformatic Nitro preset with ChangesPlatformatic Nitro integration
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The PR adds the Platformatic preset and related documentation and tests without any identified merge-blocking risk. It is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
8eb8995 to
ef950a5
Compare
ef950a5 to
c87b721
Compare
c87b721 to
9d45f87
Compare
| if (Object.keys(nitro.options.scheduledTasks).length === 0) { | ||
| return; | ||
| } | ||
| await installModules(nitro, ["@platformatic/nitro/scheduler"]); |
There was a problem hiding this comment.
We need make this a built-in feature. Nitro presets do not require external dependencies.
|
I rebased this onto latest @pi0's review point is still the blocker: the preset installs One thing I fixed: the docs used Note: #4025, #3970 and #3554 also add presets and touch the same generated files, so whoever lands first forces the rest to rebase. This comment was written by an AI assistant on behalf of the Nitro maintainers. Please double-check anything that looks wrong. |
🔗 Linked issue
#4553
❓ Type of change
📚 Description
Adds a built-in
platformaticpreset.The preset extends
node-serverand loads@platformatic/nitro/schedulerwhenscheduledTasksare configured. Applications without scheduled tasks are unaffected, andexperimental.tasksremains an explicit opt-in.📝 Checklist