Skip to content

colorschemes/ashen: init - #4178

Open
wokerNM wants to merge 5 commits into
nix-community:mainfrom
wokerNM:main
Open

wokerNM wants to merge 5 commits into
nix-community:mainfrom
wokerNM:main

Conversation

@wokerNM

@wokerNM wokerNM commented Jan 29, 2026

Copy link
Copy Markdown

Added https://codeberg.org/ficd/ashen.nvim colorscheme, and myself to maintainer list

@MattSturgeon

Copy link
Copy Markdown
Member

Please try not to open and close 4 identical PRs in the space of 15m 👀
This creates a lot of noise and notification spam.

@wokerNM

wokerNM commented Jan 29, 2026 •

Copy link
Copy Markdown
Author
  • buildbot/nix-build

Sorry, I just have no other way to test these, I will find a way to though

@wokerNM

wokerNM commented Jan 29, 2026

Copy link
Copy Markdown
Author

Please try not to open and close 4 identical PRs in the space of 15m 👀 This creates a lot of noise and notification spam.

The documentation isn't very clear, how do I test it?

@khaneliman

Copy link
Copy Markdown
Contributor

Please try not to open and close 4 identical PRs in the space of 15m 👀 This creates a lot of noise and notification spam.

The documentation isn't very clear, how do I test it?

Test what? It'll trigger CI on pushes/force-pushes.

@MattSturgeon

Copy link
Copy Markdown
Member
  • buildbot/nix-build

error: vimPlugins.ashen cannot be found in pkgs

Your PR adds a dependency that isn't found in the version of Nixpkgs Nixvim is currently using.

If you're really unfamiliar with git and github, you may wish to read some of the getting started docs 🙂

@khaneliman khaneliman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current build checks fail. Module also needs the standard matching colorscheme test before merge.

};

plugins = {
autoload = defaultNullOpts.mkBool true "";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (blocking): keep upstream settings freeform

These declarations mirror upstream settings and contain no useful descriptions. Replace settingsOptions with a representative settingsExample, as CONTRIBUTING.md recommends.

Comment thread lib/maintainers.nix
wokerNM = {
email = "wokerNM@proton.me";
github = "wokerNM";
githubId = "215592475";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
githubId = "215592475";
githubId = 215592475;

issue (blocking): use numeric GitHub ID

Maintainer githubId values are integers. Remove quotes so maintainer metadata passes expected typing and rendering.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants