Repository navigation
Fix tsgo to point to typescript instead of typescript-go - #4557
Open
ZacheryFaria wants to merge 2 commits into
Open
ZacheryFaria wants to merge 2 commits into
ZacheryFaria wants to merge 2 commits into
Conversation
ZacheryFaria
force-pushed
the
zf/update-typescript-go
branch
from
September 14, 2026 20:23
3841258 to
8a29a3d
Compare
protoniac
reviewed
Sep 22, 2026
| ts_ls = "typescript-language-server"; | ||
| ts_query_ls = "ts_query_ls"; | ||
| tsgo = "typescript-go"; | ||
| tsgo = "typescript"; |
There was a problem hiding this comment.
Shouldn't we also rename the server to tsc?
Author
There was a problem hiding this comment.
good point. i think we should
Member
There was a problem hiding this comment.
We don't define the lsp module names; we inherit them from upstream nvim-lspconfig. Attempting to rename them like this results in the following CI failure:
lsp: The following are not declared in modules/lsp/servers/packages.nix:
- tsgo
lsp: The following are not listed upstream, but are declared in modules/lsp/servers/packages.nix:- tsc
There was a problem hiding this comment.
I think that tsc is available in nvim-lspconfig
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typescript 7 (TSGO) is now just
typescriptin mainline nixpkgs,typescript-gohas been removed.