vult_full, tack and tick djin, pool - #24
Merged
Merged
Conversation
added 30 commits
June 22, 2022 01:55
added 16 commits
June 30, 2022 22:31
nmushegian
reviewed
Jul 7, 2022
| import { | ||
| vult_thin | ||
| } from './vult.js' | ||
| import {latest_fold, know, vult_full, vult_thin, vult_tack, vult_tick, subsidyleft} from './vult.js' |
Owner
There was a problem hiding this comment.
this should not be importing this many functions, it should import just 2, vult_thin, and vult_full
Owner
|
pls reopen with a smaller PR that can be merged into master, that contains just 1 new feature |
nmushegian
reviewed
Jul 8, 2022
| aver(_ => okay(form_memo(memo))[0], 'memo not well-formed') | ||
| let [wellformed, ,] = form_memo(memo) | ||
| if (!wellformed) { | ||
| // todo is this ok? |
Owner
There was a problem hiding this comment.
what are you asking here? if a memo is not well-formed that should be an error
added 2 commits
July 8, 2022 16:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.