Repository navigation
fix: reset stateful regexps when matching request data - #3011
Merged
Merged
Conversation
mikicho
approved these changes
Sep 21, 2026
Member
|
Thank you! |
|
🎉 This PR is included in version 15.0.0-beta.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset global and sticky regular expressions before comparing request data. A reused matcher in
.query()or a nested JSON body currently retainslastIndex, so the next identical request can fail to match. This applies the existing URL-matching behavior to data comparisons while leaving ordinary, potentially frozen regexps untouched.Adds regressions for repeated query/body requests and a shared regexp across object and array values. All six regressions fail before the fix; the frozen-regexp control passes on both versions.
Validation:
npm test(662 passing, 9 existing pending),npm run test:leak, andnpm run test:buildon Node 22 and 24;npm run lintandnpm run format.