Select Dropdown for Round Label - #102
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
noahm
left a comment
There was a problem hiding this comment.
Just leaving some notes as FYIs. I'll still merge and fix in the branch afterwards.
| const AppToaster = Toaster.create({ | ||
| position: Position.BOTTOM | ||
| }); |
There was a problem hiding this comment.
The app actually has a shared global toaster that can be imported instead of creating a new one here
|
|
||
| let coreControl: JSX.Element; | ||
| // Remove outline from link icon | ||
| let removeOutline = {backgroundColor: 'transparent', boxShadow: 'none', outline: 'none'}; |
There was a problem hiding this comment.
I think this can mostly be accomplished with the minimal prop on the Blueprint button component.
| { title: "Loser's Finals"}, | ||
| { title: "Casuals"}, | ||
| { title: "Warmup"}, | ||
| { title: "Freeplay"}, |
There was a problem hiding this comment.
Ideally these will all be localized strings (eventually)
| export const roundLabelProps = { | ||
| itemPredicate: filterRoundLabel, | ||
| itemRenderer: renderRoundLabel, | ||
| items: roundLabels | ||
| }; |
There was a problem hiding this comment.
This seems to be unused as all the individual members are exported separately?
| const RoundLabel = Select2.ofType<IRoundLabel>(); | ||
|
|
||
| export const RoundSelect: React.FC = () => { | ||
| const [roundLabel, setRoundLabel] = useState<IRoundLabel>(roundLabels[0]); |
There was a problem hiding this comment.
Rather than save this as state local to this component, we need to save this to the state of the drawing (which will then cause it to sync over the network, when enabled)
Updated round label from text field to a dropdown with commonly used round labels used in standard double elimination tournaments.