Skip to content

SDVX Import Suggested Fixes#37

Merged
noahm merged 11 commits into
noahm:sdvx-importfrom
vlnguyen:sdvx-import-suggestions
Jul 13, 2020
Merged

SDVX Import Suggested Fixes#37
noahm merged 11 commits into
noahm:sdvx-importfrom
vlnguyen:sdvx-import-suggestions

Conversation

@vlnguyen

@vlnguyen vlnguyen commented Jul 12, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Distinguish the different difficulty classes that exist within the INFINITE difficulty class, (INF, GRV, HVN, VVD).
  • Change difficulty class colors to be more vibrant and suggested a default difficulty range of 16-19 on load.
  • Implement chart-level jackets, and added functionality to SDVX music_db.xml imports to determine the jacket filenames.
  • Uploaded the SDVX song jackets.

noahm
noahm reviewed Jul 13, 2020
View reviewed changes

@noahm noahm left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I can merge as-is and address these points myself or let you touch it up if you want to for the fun of it.

Comment thread scripts/import-sdvx.js Outdated
Comment thread scripts/import-sdvx.js Outdated
Comment thread scripts/import-sdvx.js
Comment thread scripts/import-sdvx.js
@noahm
noahm merged commit 5621a12 into noahm:sdvx-import Jul 13, 2020
@vlnguyen
vlnguyen deleted the sdvx-import-suggestions branch May 1, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noahm noahm noahm left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vlnguyen @noahm