Skip to content

tools: do not hardcode path to Ruff - #65681

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:nix-ruff
Open

tools: do not hardcode path to Ruff#65681
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:nix-ruff

Conversation

@aduh95

@aduh95 aduh95 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Allows user to get Ruff from other source than Pip (e.g. Nix).

Without this change I'm getting an error about Pip not being installed.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Aug 31, 2026
@github-actions

This comment was marked as outdated.

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.06%. Comparing base (a844473) to head (1a02a56).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65681      +/-   ##
==========================================
- Coverage   90.07%   90.06%   -0.02%     
==========================================
  Files         754      754              
  Lines      256378   256378              
  Branches    48498    48492       -6     
==========================================
- Hits       230936   230900      -36     
- Misses      16572    16581       +9     
- Partials     8870     8897      +27     

see 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Allows user to get Ruff from other source than Pip (e.g. Nix).

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor
Platform Number of requisites Proportion of new derivations
x86_64-linux 485 -> 487 => +2 2 / 487 = 0.4%
aarch64-linux 486 -> 488 => +2 2 / 488 = 0.4%
x86_64-darwin 427 -> 428 => +1 1 / 428 = 0.2%
aarch64-darwin 428 -> 430 => +2 2 / 430 = 0.4%
Total 1826 -> 1833 => +7 7 / 1833 = 0.3%
Changelog
@@ -492,0 +493,2 @@
+/nix/store/fq39rhap6r4bl0wsll3hfqjrp1nsilda-jemalloc-5.3.1 (aarch64-darwin)
+/nix/store/w0pibr5hh7yk8s7fh03yr3af07rwv5xz-jemalloc-5.3.1 (aarch64-linux)
@@ -493,0 +496 @@
+/nix/store/z6rg3rxxrw2mvswrxn6087hrra3ng0wd-jemalloc-5.3.1 (x86_64-linux)
@@ -1585,0 +1589,4 @@
+/nix/store/01gj4zr9wpn9b6ci511gqpndkra4g229-ruff-0.15.14 (x86_64-darwin)
+/nix/store/wsbkwpqbn2nkdhs8b1kw9dkr6mzz7lrb-ruff-0.16.3 (aarch64-darwin)
+/nix/store/jk435qaa4v9h05wwv02ap2kl2cwncnia-ruff-0.16.3 (aarch64-linux)
+/nix/store/sddv779f9zwcm72i0nsa8sgy1zjcl2n4-ruff-0.16.3 (x86_64-linux)

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants