Repository navigation
Add a host convolver and CONVO, a convolution reverb (Matt Parrett's #34, rebased) - #41
Merged
Merged
Conversation
…h an IR (prototype) A machine declares an impulse response with `convolver` (an asset kind), and the host convolves the stereo input with it by uniform partitioned overlap-save (256-sample partitions, the fixed FFT in src/fft.zig), handing the kernel the result per sample as io.cv-l / io.cv-r, 256 samples late. The engine is built off the audio thread and published with the asset bindings; a replaced one retires through the same handoff. Effects now load and save their asset files in projects, so a project can pick the IR. Prototype for listening before a proposal: the IR is built for 48 kHz only, a swap has no crossfade, and four-channel true-stereo IRs aren't read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An effect can now load a file by asset name from a song script, which
CONVO's IR needs: fx("convo", assets={"room": ...}). A preset's own
assets come with it, as they do on tracks; no effect preset carried any
before CONVO's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The host convolves the input with an impulse response; PREDELAY, LO CUT, HI CUT, WIDTH, LEVEL and MIX run in fy after it, with the dry delayed to line up. Two IRs ship: a synthetic stereo hall and a bowed cymbal from VSCO 2 CE (CC0), with a preset each. docs/46 describes the convolver and its limits: the IR is built for 48 kHz, a swap doesn't crossfade, and the partitions are uniform. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…h CONVO IR Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matt Parrett's #34, rebased onto current master (changelog and docs/README conflicts resolved, the convolver doc renumbered to docs/49 because 46 is recovery and logs). His commits and authorship are kept; tests pass.
Supersedes #34.
🤖 Generated with Claude Code