Skip to content

ci: add COPR build validation on release PRs - #1572

Merged
SequeI merged 1 commit into
mainfrom
COPRbuild
Aug 4, 2026
Merged

ci: add COPR build validation on release PRs#1572
SequeI merged 1 commit into
mainfrom
COPRbuild

Conversation

@SequeI

@SequeI SequeI commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Linked Issue

Ref #1570

Summary

Run build-srpm.sh and mock-rebuild the resulting SRPM inside a clean Fedora 42 chroot on all chore: release v* PRs. Catches spec and vendored-cargo build failures before the tag is pushed.

@Doooooo0o quick question: is the COPR submission step automated somewhere, or are you manually running build-srpm.sh and submitting to COPR after each release? Asking because there's no COPR step in the release workflow and it's not in notify-downstream either. If it's manual, it'd be worth wiring up copr-cli in release.yml so it submits automatically on tag, anyways happy to look at that if you can confirm.

Test Plan

Checklist

  • An issue exists and is linked above
  • All commits are signed-off, using DCO
  • All new code follows the project's coding standards (CLAUDE.md) and is covered by tests
  • Public-facing changes are paired with documentation updates

@gemini-code-assist

gemini-code-assist Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@github-actions github-actions Bot added ci CI/CD changes size/medium labels Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Review Summary

Size

Metric Value
Lines added +121
Lines removed -59
Total changed 180
Classification Medium (50–300 lines)

Affected crates

No crate source directories are directly affected.

Blast radius — Contained

This PR touches: CI / build tooling

Updated automatically on each push to this PR.

nogent-nolabs-ai[bot]
nogent-nolabs-ai Bot reviewed Aug 4, 2026
View reviewed changes

@nogent-nolabs-ai nogent-nolabs-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nogent code review

1 high-severity bug and 2 low-severity issues identified.

Automated code + security review. CI already covers clippy, rustfmt, tests, cargo-audit and commit-lint.

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
@SequeI SequeI changed the title ci: add COPR build validation on release PRs chore: release v7.2 test Aug 4, 2026
@github-actions github-actions Bot added chore Maintenance and housekeeping and removed ci CI/CD changes labels Aug 4, 2026
@SequeI SequeI changed the title chore: release v7.2 test ci: add COPR build validation on release PRs Aug 4, 2026
@github-actions github-actions Bot removed the chore Maintenance and housekeeping label Aug 4, 2026
@SequeI
ci: add COPR build validation on release PRs
8c37d95 
Run build-srpm.sh and mock-rebuild the resulting SRPM inside a clean
Fedora 42 chroot on all chore: release v* PRs. Catches spec and
vendored-cargo build failures before the tag is pushed.

Signed-off-by: Aleksy Siek <aleksy@alwaysfurther.ai>
@github-actions github-actions Bot added the ci CI/CD changes label Aug 4, 2026
@SequeI
SequeI merged commit c2422a7 into main Aug 4, 2026
21 checks passed
@Doooooo0o

Doooooo0o commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Linked Issue

Ref #1570
@Doooooo0o quick question: is the COPR submission step automated somewhere, or are you manually running build-srpm.sh and submitting to COPR after each release? Asking because there's no COPR step in the release workflow and it's not in notify-downstream either. If it's manual, it'd be worth wiring up copr-cli in release.yml so it submits automatically on tag, anyways happy to look at that if you can confirm.

I'm triggering the script manually at this stage, happy to help automate it fully :-)

@SequeI

SequeI commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

I'm triggering the script manually at this stage, happy to help automate it fully :-)

That would be great! I have created #1576 which I will assign to you, no pressure this is just a nice to have release stability, no deadline or anything. And if you don't feel like doing it, also don't worry just lmk and I can take over! Thanks again!

@SequeI
SequeI deleted the COPRbuild branch August 5, 2026 13:39
@scottames-github-bot scottames-github-bot Bot mentioned this pull request Aug 16, 2026
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kurtisc kurtisc kurtisc approved these changes
+1 more reviewer
@nogent-nolabs-ai nogent-nolabs-ai[bot] nogent-nolabs-ai[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci CI/CD changes size/medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SequeI @Doooooo0o @kurtisc