Skip to content

feat(cleanup)!: remove remaining deprecated surfaces - #1871

Merged
SequeI merged 3 commits into
mainfrom
removeLegacy2
Sep 14, 2026
Merged

SequeI merged 3 commits into
mainfrom
removeLegacy2

Conversation

@SequeI

@SequeI SequeI commented Sep 11, 2026 •

Copy link
Copy Markdown
Member

Linked Issue

Closes #1867

Summary

Remove obsolete diagnostic, trust policy, profile, and proxy APIs.
Reject removed profile fields and update schemas, examples, and docs.

Test Plan

Checklist

  • An issue exists and is linked above
  • All commits are signed-off, using DCO
  • All new code follows the project's coding standards (CLAUDE.md) and is covered by tests
  • Public-facing changes are paired with documentation updates
  • If this PR introduces a major feature, capability, or security-relevant change, a corresponding NEP has been opened or accepted and is linked

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

PR Review Summary

Size

Metric Value
Lines added +41
Lines removed -226
Total changed 267
Classification Medium (50–300 lines)

Affected crates

  • crates/nono (core library) — careful review required. This is the security-critical sandbox primitive. A bug here bypasses OS-level isolation for every downstream user.
  • crates/nono-proxy — downstream consumers depend on this crate. API or behaviour changes will affect external callers; treat any breaking change with extra scrutiny.
  • crates/nono-cli — CLI changes. Verify argument parsing, flag documentation, and UX behaviour across supported platforms.

Blast radius — Broad

This PR touches: source code,documentation,configuration / policy files


Updated automatically on each push to this PR.

@nogent-nolabs-ai nogent-nolabs-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nogent code review

No blocking issues; 1 documentation nit.

Findings (not tied to a changed line):

  • 💬 [LOW · nit] crates/nono-cli/README.md:134 — In crates/nono-cli/README.md, the documentation still lists interactive under the boolean merging behavior section: - **Booleans** (network.block, interactive): OR — either activates. Since interactive has been completely removed in this PR, update this line to remove interactive from the explanation.

Automated code + security review. CI already covers clippy, rustfmt, tests, cargo-audit and commit-lint.

  Remove obsolete diagnostic, trust policy, profile, and proxy APIs.
  Reject removed profile fields and update schemas, examples, and docs.

Signed-off-by: Aleksy Siek <aleksy@nolabs.ai>
Signed-off-by: Aleksy Siek <aleksy@nolabs.ai>
Signed-off-by: Aleksy Siek <aleksy@nolabs.ai>
@SequeI
SequeI merged commit 9488c4c into main Sep 14, 2026
17 checks passed
@SequeI
SequeI deleted the removeLegacy2 branch September 14, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ignored profile interactive field

2 participants