Repository navigation
Conversation
This adds rust-toolchain.toml and rustfmt.toml and setting 1.95 as the rust version to be used. This allows every dev working on nono to be on the same rust version and avoids any version related inconsitencies Signed-off-by: Eyob <eyobxz@icloud.com>
Contributor
PR Review SummarySize
Affected cratesNo crate source directories are directly affected. Blast radius — ContainedThis PR touches: configuration / policy files Updated automatically on each push to this PR. |
| @@ -0,0 +1,4 @@ | |||
| [toolchain] | |||
| channel = "1.95" | |||
There was a problem hiding this comment.
Caution
🐛 [HIGH · bug] The specified Rust channel 1.95 in rust-toolchain.toml is a future, unreleased Rust version (Edition 2024 is stable starting in 1.85). Because rustup intercepts and enforces the toolchain override specified in rust-toolchain.toml for every cargo command, setting this to an unreleased version will immediately cause all local commands and CI builds to fail with a toolchain resolution error. Change channel to a valid, released Rust version (such as 1.85 or stable), and update the matching rust-version field in Cargo.toml accordingly.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds rust-toolchain.toml and rustfmt.toml and setting 1.95 as the rust version to be used.
This allows every dev working on nono to be on the same rust version and avoids any version related inconsitencies
Linked Issue
issue
Closes #2038
Summary
Adds a rust-toolchain.toml and rustfmt.toml
Test Plan
Run cargo fmt
Checklist