Repository navigation
Conversation
The card images had a hard-coded white background, left from the light-only Mintlify cards, so in dark mode each photo sat on a white panel. The photos are transparent PNGs, so show them on the card, as the driver pages already do. Light mode keeps the white panel. Closes #631 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @arsenovic's task in 54s —— View job Code Review
Summary: Small, well-scoped CSS fix (4 lines, one file). The dark-mode override targets the same selector the light-mode rule already uses, the explanatory comment matches the file's existing comment style (why, not what), and the "no test" rationale in the PR body is appropriate for a CSS-only visual change with no test harness for rendered styles. No driver/API/docs-sync concerns apply here — this isn't a new driver or public API change. No inline findings — nothing to flag. |
|
Closes #631.
In dark mode, the product photos on the driver cards (instruments and each category page) sat on a white panel. The same photos on the driver pages (e.g. Keysight1200X) show on the page's dark background.
Cause
docs/_static/custom.cssgave.driver-card .sd-card-img-bottoma hard-codedbackground: #fff, carried over from the light-only Mintlify cards. The driver-page image (img.driver-image) sets no background.Change
docs/_static/custom.css: underhtml.dark, the card image background istransparent. Light mode keeps the white panel.52 of the 54 driver photos are RGBA PNGs, so they show cleanly on the dark card.
docs/daq/MCCDriver.pngis plain RGB, so it keeps its own baked-in background in both places, as it already does on its driver page.Why no test
This is a CSS-only change. There's no test harness for rendered styles; I checked it visually instead (below).
Testing
/instruments/in dark mode: the card photos sit on the dark card, matching the driver pages.instro.lib.discover.VisaInstrumentInfo.rst, an alias since feat(discover): add dataclass for discovered instruments with driver and config builders #620). A fresh checkout doesn't have it; the docs check on this PR confirms.🤖 Generated with Claude Code