Repository navigation
fix: Issue 534 transformation tests failing on some platforms - #559
Merged
boxanm merged 3 commits intoJan 31, 2024
Merged
Conversation
boxanm
requested review from
aguenette and
simonpierredeschenes
as code owners
January 23, 2024 15:16
aguenette
approved these changes
Jan 23, 2024
simonpierredeschenes
approved these changes
Jan 24, 2024
|
Collaborator
Author
|
The arm64 build randomly falls on the build farm. Since this issue wasn't encountered locally on an arm machine, we assume it was due to the CPU architecture virtualization. |
boxanm
deleted the
issue_534-transformation-tests-failing-on-some-platforms
branch
January 31, 2024 21:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary:
The 3D Transformation utests were failing on Ubuntu Bionic with Eigen 3.3.4, in contrast to all other platforms tested with Eigen 3.4.
I added a non-zero epsilon precision value to Eigen's
isApproxcall for Rotation and Rotation+Scaling tests.My guess is the two versions of Eigen treat zero epsilon precision values differently; hence the tests weren't failing with 3.4.0.
Fixes #534
Changes and type of changes (quick overview):
isApproxin failing Transformation utest.Checklist:
Code related
(i.e.: function, class, script header, README.md)
(Check README.md #Contributing
for local testing procedure using libpointmatcher-build-system)
PR creation related
base refbranch is set to thedevelopbranch(the build-system won't be triggered otherwise)
developbranch(the build-system will reject it otherwise)
PR description related
# <issue-id>if changes are of typefixfeatfixdocsstylerefactorperftestbuildcichorerevert<type>!see commit_msg_reference.md
in the repository root for details
Note for repository admins
Release PR related
push/mergeon the default branch (ie:master)and the
releasebranch.draftmode until all the release reviewers are ready to push the release.release->masterbranch is created (not in draft mode),