Skip to content

Avoid loss of precision in update_dimensions #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jangler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid loss of precision in update_dimensions #583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/native/windows.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,13 +799,13 @@ impl WindowsDisplay {
if GetClientRect(hwnd, &mut client_rect as *mut _ as _) != 0 {
// Calculate window width and height based on the client area
let window_width =
((client_rect.right - client_rect.left) as f32 / self.window_scale) as i32;
(client_rect.right - client_rect.left) as f32 / self.window_scale;
let window_height =
((client_rect.bottom - client_rect.top) as f32 / self.window_scale) as i32;
(client_rect.bottom - client_rect.top) as f32 / self.window_scale;

// Prevent a framebuffer size of 0 when the window is minimized
let fb_width = ((window_width as f32 * self.content_scale) as i32).max(1);
let fb_height = ((window_height as f32 * self.content_scale) as i32).max(1);
let fb_width = ((window_width * self.content_scale).round() as i32).max(1);
let fb_height = ((window_height * self.content_scale).round() as i32).max(1);
Comment on lines +807 to +808
Copy link

@TomFryersMidsummer TomFryersMidsummer Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

round_ties_even is a bit less biased and faster.


// Check for size changes
if fb_width != d.screen_width || fb_height != d.screen_height {
Expand Down
Loading