Expose window HWND on Windows (mirrors apple_view() on macOS)#603
Open
TheRedDeveloper wants to merge 1 commit intonot-fl3:masterfrom
Open
Expose window HWND on Windows (mirrors apple_view() on macOS)#603TheRedDeveloper wants to merge 1 commit intonot-fl3:masterfrom
TheRedDeveloper wants to merge 1 commit intonot-fl3:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
window::windows_hwnd()function that returns the main window's HWND as*mut c_void, analogous to the existingwindow::apple_view()on macOS.Issue
Downstream crates that integrate with Windows platform APIs (accessibility via UI Automation / AccessKit, drag-and-drop, theming, etc.) need the HWND but currently can't access it since
WindowsDisplay.wndispub(crate).Solution
windows.rs: Added a staticWINDOW_HWNDthat is set immediately afterCreateWindowExW, and a publicget_window_hwnd()function.lib.rs: Addedwindow::windows_hwnd()(gated behind#[cfg(target_os = "windows")]).It's just a new public function I need to implement accessibility features on Windows.