You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Dagesh overlaps in heavier weights of Noto Sans Hebrew #47
The dagesh can sometimes overlap the next letter in the heavier weights as seen in the screenshots below. This seems to affect Black, SemiCondensed Black, Condensed Black, ExtraCondensed Black, Condensed ExtraBold, and ExtraCondensed ExtraBold.
Activity
MAZ06 commentedon Apr 22, 2024
@simoncozens It seems that this is not fully fixed.
The יּה works now, but יּע still does not.


MAZ06 commentedon Apr 22, 2024
These too:










וּש
וּג
וּט
וּך
וּכ
וּס
וּף
וּפ
וּץ
יּע
יּש
יּג
יּט
יּכ
יּס
יּפ
יּץ
MAZ06 commentedon Apr 22, 2024
And then these are cutting it pretty close:


וּם
וּמ
וּח
וּה
וּת
וּר
וּנ
וּן
יּד
MAZ06 commentedon Apr 22, 2024
Almost every letter combination with yod and vav would have to have its own dagesh form if you're going to do it the way I saw in your code.
simoncozens commentedon Apr 22, 2024
I don't think I'm doing it the way you think I'm doing it. :-)
The dagesh combines with the yod/vav to make a "dagesh form", not the letter after it. We just need a bit of kerning on those two glyphs.
MAZ06 commentedon Apr 22, 2024
Apologies. I'm obviously not much of a coder. But thanks for reopening this issue.
MAZ06 commentedon Jun 4, 2024
I retested all of these with the new Sans font:

Looks mostly fixed but a few are either still overlapping or cutting it pretty close:



וּס
וּפ
יּכ
Use precomposed dagesh forms, improve spacing of them, fixes notofont…