Repository navigation
Draw the p, f, k and kh ligatures with l and m, and release 3.103 - #50
Merged
Merged
Conversation
Take the ligatures the unified font draws but the standard does not ask for: the 16 drawings of _PL/_PM/_FL/_FM/_KL/_KM/_K2L/_K2M in initial and medial position, the ligature glyphs the OTL composer builds from them, and the rebuilt features.fea. The rebuild also carries the fix for the o/u/oe/ue marking after a word-initial consonant cluster, which is now restricted to the medial form.
Contributor
|
Thank you. I'll check the generated binaries for vmtx/vhea before we cut a release. |
Contributor
Author
|
Thank you. BTW please also notice notofonts/khitan-small-script#3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The ligatures of p, f, k and kh with l and m: sixteen drawings (
_PL,_PM,_FL,_FM,_KL,_KM,_K2L,_K2M, each.initand.medi), the twenty-four ligature glyphs the OTL composer builds from them, a rebuiltfeatures.fea, and the version bumped to 3.103.p l au182B.P.init nirugu.extend u182F.L.medi u1820.A.finau182B_u182F.PL.init u1820.A.finap m au182B.P.init nirugu.extend u182E.M.medi u1820.A.finau182B_u182E.PM.init u1820.A.finaf l au1839.F.init nirugu.extend u182F.L.medi u1820.A.finau1839_u182F.FL.init u1820.A.finak l au183B.K.init nirugu.extend u182F.L.medi u1820.A.finau183B_u182F.KL.init u1820.A.finak2 l au183A.K2.init nirugu.extend u182F.L.medi u1820.A.finau183A_u182F.K2L.init u1820.A.finaand the same in medial position. The word-final l and m keep the
nirugu.extendinsertion, as they do now: no ligature is drawn for them, followingBL/BM.These are a choice of this font rather than something the standard asks for — GB/T 25914—2023 does not list them — so the drawings are in the unified source and the ligatures are taken by the unified composer alone, not by the ligature table the standard fonts share.
Follows up on:
Also in the rebuilt
features.feaThe
markedform of o / u / oe / ue that an initial consonant asks for is now carried across a consonant cluster to the medial vowel only, as GB/T 25914—2023 tables B.13/B.14 have it. A word-final vowel after a word-initial consonant cluster keeps its default form (n n oe→u1825.U.fina, notu1825.Ue.fina), while a single initial consonant still marks it (n oe→u1825.Ue.fina). This is the fix for Kushim-Jiang/mongolian#60.Verification
The source compiles, and each of the eight pairs ligates in initial and medial position.
Shaping the Mongolian suites, exactly four cases change — the ligature replacing the
nirugu.extendinsertion, and nothing else:core-hud > syllabic-o/u-5u183A.K2.init nirugu.extend u182F.L.medi …u183A_u182F.K2L.init …core-mag > pu2-bowedu183A.K2.init nirugu.extend u182F.L.medi …u183A_u182F.K2L.init …eac-hud > MPS11-51u182B.P.init nirugu.extend u182F.L.medi …u182B_u182F.PL.init …eac-hud > XKS11-52u183B.K.init nirugu.extend u182F.L.medi …u183B_u182F.KL.init …The stored expectations in
qa/shaping_tests/are updated for those four; every other case is unchanged.Version bumped to 3.103 (both
versionMinorandopenTypeNameVersion).Note
The rebuilt
features.feacomes from themongfontbuilderworking tree, which carries the o/u/oe/ue fix beyond the pinned 0.15.3.requirements.txtstill pins 0.15.3, so the pin needs the release that carries the fix beforemake shapingreproduces these locks. As before,scripts/gen_shaping_tests.pyis not in the tree; the locks here were regenerated by replaying the shaping suites directly.