Implement GSSAPI session encryption - #6131
Merged
Merged
Conversation
vonzshik
force-pushed
the
2957-gssapi-session-ecnryption
branch
from
June 5, 2025 15:51
b0edd1d to
cdc45cf
Compare
vonzshik
marked this pull request as ready for review
June 6, 2025 12:26
Contributor
Author
|
OK, it's ready. The important docs to read are: protocol flow, require_auth and gsencmode. Current implementation should follow libpq, with a single difference: we have |
roji
requested changes
Jun 10, 2025
roji
left a comment
Member
There was a problem hiding this comment.
See initial review - mostly nits, it looks generally just fine. Main thoughts on my side:
- Can we factor more common code between GSS auth and encrypt modes? There seems to be a bit of duplication.
- There may also be some opportunities for doing things more similarly across SSL and GSS encryption (e.g. see comment on retry below).
- Can we use .NET NegotiateStream rather than implementing our own GSSStream?
This was referenced Aug 17, 2026
Closed
This was referenced Aug 25, 2026
This was referenced Sep 1, 2026
Closed
This was referenced Sep 9, 2026
Closed
This was referenced Sep 17, 2026
Bump the dotnet-dependencies group with 8 updates
SaiTejaReddyYeldandi/CSharp_RiskFeed_Automation#10
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2957