lint W59/E60: don't check vcs upstream - #4635
Conversation
|
What's actually checked with an rsync URL? |
|
From dev meeting: the test needs to be http or rsync pointing to a file (rather than a directory) |
|
This could potentially have a test for whether a checksum has been added when there shouldn't be one |
kit-ty-kate
left a comment
There was a problem hiding this comment.
Tested successfully and looks good to me overall. I think the details about rsync can be figured out later, it's less critical.
The rsync file/directory part should be figured out now (we shouldn’t close one bug by creating another), but I agree the extra checksum check can wait. Regardless, please can issues be opened to track anything which isn’t fixed now 🙂 |
|
Just finished both, no need of new issue :) |
|
reviewed mechanism and add E67 for url present and no archive url ping @kit-ty-kate |
|
I've tested a number of cases with it and it seems good to go for me. |
Highlighted in ocurrent/opam-repo-ci#93