Skip to content

lint W59/E60: don't check vcs upstream - #4635

Merged
dra27 merged 3 commits into
ocaml:masterfrom
rjbou:lint-dl
Apr 23, 2021
Merged

dra27 merged 3 commits into
ocaml:masterfrom
rjbou:lint-dl

Conversation

@rjbou

@rjbou rjbou commented Apr 15, 2021

Copy link
Copy Markdown
Collaborator

Highlighted in ocurrent/opam-repo-ci#93

@rjbou rjbou added this to the 2.1.0~rc milestone Apr 15, 2021
@dra27

dra27 commented Apr 16, 2021

Copy link
Copy Markdown
Member

What's actually checked with an rsync URL?

@dra27

dra27 commented Apr 16, 2021

Copy link
Copy Markdown
Member

From dev meeting: the test needs to be http or rsync pointing to a file (rather than a directory)

@dra27

dra27 commented Apr 16, 2021

Copy link
Copy Markdown
Member

This could potentially have a test for whether a checksum has been added when there shouldn't be one

@kit-ty-kate kit-ty-kate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully and looks good to me overall. I think the details about rsync can be figured out later, it's less critical.

@dra27

dra27 commented Apr 16, 2021

Copy link
Copy Markdown
Member

I think the details about rsync can be figured out later, it's less critical.

The rsync file/directory part should be figured out now (we shouldn’t close one bug by creating another), but I agree the extra checksum check can wait. Regardless, please can issues be opened to track anything which isn’t fixed now 🙂

@rjbou

rjbou commented Apr 16, 2021

Copy link
Copy Markdown
Collaborator Author

Just finished both, no need of new issue :)
In fact the good check is too look is it is an archive url, regardless of the backend

@rjbou

rjbou commented Apr 16, 2021

Copy link
Copy Markdown
Collaborator Author

reviewed mechanism and add E67 for url present and no archive url ping @kit-ty-kate

@kit-ty-kate

Copy link
Copy Markdown
Member

I've tested a number of cases with it and it seems good to go for me.

@dra27
dra27 merged commit 9e02cb2 into ocaml:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants