Update working dir - #3759
Merged
Merged
Update working dir#3759
Conversation
avsm
reviewed
Feb 25, 2019
| in | ||
| let args = [ | ||
| "--files-from"; (Lazy.force convert_path) stdout_file; | ||
| "--exclude"; "_build"; (* tiny clean: exclude _build directory *) |
Member
There was a problem hiding this comment.
I believe rsync supports .gitignore files, so a future improvement to this hardcoded _build directory could be adding --filter=":- .gitignore" to the command line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
working-diroption didn't copy all local files, just uncomiited changes of version controlled ones, which leads to some rsync errors (if a file is deleted), and not handling new ones.This PR changes this behavior by copying all current source directory (except
_builddirectory). It may result to some build failure is current source directory is not clean.