Default-ish dune flags #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The CI failure has been reported at ocaml/infrastructure#60. There's still some weirdness about warning 50, since older OCaml version don't like some of our documentation comments, whereas newer versions (and on my local machine) work fine and don't report issues. |
Member
Author
|
I'll probably rebase this on #167 when that one is merged to look at the failures due to warning 50 on some older OCaml versions in more detail. |
Contributor
|
LGTM |
53116f0 to
6bf0c38
Compare
This way we don't have meaningful dangling whitespace at the start and end of files and ocamlformat doesn't try to remove it.
d6af517 to
a5de873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #165.