Split compilation units #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2023
Merged
89a67a7 to
4cec3b1
Compare
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Oct 10, 2023
CHANGES: *2023-10-10* ### Changed - Make `Basic`, `Safe` & `Raw` seperate compilation units that get exposed by the main module as suggested by @hhugo to enable JSOO to discard unused modules. No API changes should be observable. (ocaml-community/yojson#84, ocaml-community/yojson#167 @Leonidas-from-XIV) - Removed forward refs in the parser to make dead-code elimination in JSOO better (ocaml-community/yojson#168, @hhugo)
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Oct 10, 2023
CHANGES: *2023-10-10* - Make `Basic`, `Safe` & `Raw` seperate compilation units that get exposed by the main module as suggested by @hhugo to enable JSOO to discard unused modules. No API changes should be observable. (ocaml-community/yojson#84, ocaml-community/yojson#167 @Leonidas-from-XIV) - Removed forward refs in the parser to make dead-code elimination in JSOO better (ocaml-community/yojson#168, @hhugo)
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Oct 10, 2023
CHANGES: *2023-10-10* - Make `Basic`, `Safe` & `Raw` seperate compilation units that get exposed by the main module as suggested by @hhugo to enable JSOO to discard unused modules. No API changes should be observable. (ocaml-community/yojson#84, ocaml-community/yojson#167 @Leonidas-from-XIV) - Removed forward refs in the parser to make dead-code elimination in JSOO better (ocaml-community/yojson#168, @hhugo)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: *2023-10-10* - Make `Basic`, `Safe` & `Raw` seperate compilation units that get exposed by the main module as suggested by @hhugo to enable JSOO to discard unused modules. No API changes should be observable. (ocaml-community/yojson#84, ocaml-community/yojson#167 @Leonidas-from-XIV) - Removed forward refs in the parser to make dead-code elimination in JSOO better (ocaml-community/yojson#168, @hhugo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @hhugo in #84 (comment) this reshuffles the file contents to make
Basic,Safe&Raw(& an unnamed toplevel module, namedTfor lack of a better name) separate compilation units. This should hopefully bring down compilation size and as a side-effect it also removes a bit of copying asCommonandCodecbecame their own modules so their content is not duplicated in multiple places.It makes the
dunefile a bit more complex because it generates more files now but I believe the code is a bit more readable now.