Remove forward ref in the lexer #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The forward ref make jsoo deadcode elimination ineffective
Contributor
Author
|
@Leonidas-from-XIV, feel free to take over this PR. |
Leonidas-from-XIV
approved these changes
Aug 2, 2023
Member
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
Looks reasonable to me and honestly a bit nicer than the optjunk32 business.
I think this area of Yojson is under-tested since we have any tests on parsing errors.
Contributor
Author
|
@Leonidas-from-XIV, can this be merged ? |
Member
|
@hhugo If you consider this PR finished (to me it seems so), it looks fine to me and ok to merge. |
Contributor
Author
|
This PR is ready from my perspective |
Member
|
Thanks for the contribution! Might be worth cutting a patch release to help JSOO users. |
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Oct 10, 2023
CHANGES: *2023-10-10* ### Changed - Make `Basic`, `Safe` & `Raw` seperate compilation units that get exposed by the main module as suggested by @hhugo to enable JSOO to discard unused modules. No API changes should be observable. (ocaml-community/yojson#84, ocaml-community/yojson#167 @Leonidas-from-XIV) - Removed forward refs in the parser to make dead-code elimination in JSOO better (ocaml-community/yojson#168, @hhugo)
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Oct 10, 2023
CHANGES: *2023-10-10* - Make `Basic`, `Safe` & `Raw` seperate compilation units that get exposed by the main module as suggested by @hhugo to enable JSOO to discard unused modules. No API changes should be observable. (ocaml-community/yojson#84, ocaml-community/yojson#167 @Leonidas-from-XIV) - Removed forward refs in the parser to make dead-code elimination in JSOO better (ocaml-community/yojson#168, @hhugo)
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Oct 10, 2023
CHANGES: *2023-10-10* - Make `Basic`, `Safe` & `Raw` seperate compilation units that get exposed by the main module as suggested by @hhugo to enable JSOO to discard unused modules. No API changes should be observable. (ocaml-community/yojson#84, ocaml-community/yojson#167 @Leonidas-from-XIV) - Removed forward refs in the parser to make dead-code elimination in JSOO better (ocaml-community/yojson#168, @hhugo)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: *2023-10-10* - Make `Basic`, `Safe` & `Raw` seperate compilation units that get exposed by the main module as suggested by @hhugo to enable JSOO to discard unused modules. No API changes should be observable. (ocaml-community/yojson#84, ocaml-community/yojson#167 @Leonidas-from-XIV) - Removed forward refs in the parser to make dead-code elimination in JSOO better (ocaml-community/yojson#168, @hhugo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forward ref make jsoo deadcode elimination ineffective.
Fix #84 to some degree.