Added failing test on parsing failure #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonidas-from-XIV
approved these changes
Nov 16, 2023
Member
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
Thanks, this will come helpful to fix and as regression test!
There might be some simplifications possible due to this, in particular some spurious -1 and then accompanying +1 that can most likely be removed but for now this should fix the problem.
Member
|
It was indeed due to #168, which was advancing the parser as it was reading "junk" (that is the unparseable bits after the parser failure). There is still some wonkiness happening that I would like to look into (adding 1 and subtracting 1 in other places seems a bit odd) but this will at least fix the regression. |
This was referenced Nov 23, 2023
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Nov 23, 2023
CHANGES: *2023-11-23* ### Fixed - Fix the error location reported in the exception. Regression in 2.1.1 (reported by @johnridesabike, regression test by @ElectreAAS, fix by @Leonidas-from-XIV, ocaml-community/yojson#171, ocaml-community/yojson#172)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: *2023-11-23* ### Fixed - Fix the error location reported in the exception. Regression in 2.1.1 (reported by @johnridesabike, regression test by @ElectreAAS, fix by @Leonidas-from-XIV, ocaml-community/yojson#171, ocaml-community/yojson#172)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test that currently fails, to highlight the problem raised in #171.