refactor(github)!: deprecate legacy hub plugin - #14089
Open
robbyrussell wants to merge 3 commits into
Open
robbyrussell wants to merge 3 commits into
robbyrussell wants to merge 3 commits into
Conversation
BREAKING CHANGE: the github plugin is deprecated and will be removed in a future release. Use the gh plugin for GitHub CLI completion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standards checklist:
Changes:
githubplugin, which supports the legacyhubCLI, and direct GitHub CLI users to theghplugin.hubbehavior during the deprecation period while making the repository helpers use the current branch and stop after a failed directory change.githubdocumentation with migration guidance forgh repo create.ghcompletion cache when completion generation fails.ghcompletion cache location.Testing:
zsh -nagainst both plugin files.git diff --check.oh-my-zsh.sh.exist_ghdoes not callhubafter a failedcdand pushesHEADfor a valid directory.Other comments:
GitHub CLI is not a drop-in Git wrapper, so this intentionally does not replace
alias git=hubwithgh. Existinghubusers retain the old behavior until the deprecated plugin is removed.AI-assisted: OpenCode assisted with research, implementation, and test setup; the resulting changes were reviewed and tested manually.