Skip to content

virtualenvwrapper plugin fix #112852 - #12853

Closed
mvk wants to merge 1 commit into
ohmyzsh:masterfrom
mvk:mvk/12852
Closed

mvk wants to merge 1 commit into
ohmyzsh:masterfrom
mvk:mvk/12852

Conversation

@mvk

@mvk mvk commented Dec 18, 2024 •

Copy link
Copy Markdown

when we're not in enabled mode and DISABLE_VENV_CD=1:

  • safely delete the chpwd hook workon_cwd if it were previously set up

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • see the diff :)

Other comments:

  • tested only manually

...

@ohmyzsh ohmyzsh Bot added the Area: plugin Issue or PR related to a plugin label Dec 18, 2024
when we're not in enabled mode and `DISABLE_VENV_CD=1`:
  - safely delete the chpwd hook `workon_cwd` if it were previously set up

Signed-off-by: Maxim Kovgan <makovgan@redhat.com>
@mvk

mvk commented Apr 18, 2026

Copy link
Copy Markdown
Author

closing since the corresponding issue #12852 is a non-issue

@mvk mvk closed this Apr 18, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Main project Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: plugin Issue or PR related to a plugin

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant