This repository was archived by the owner on Jan 2, 2026. It is now read-only.
Repository navigation
Spring cleaning - #257
Merged
Merged
Spring cleaning#257
Conversation
nmay231
commented
Jan 6, 2020
Collaborator
- Please check if the PR fulfills these requirements
- The commit message(s) are descriptive of the changes made
- The PR contains changes that are focused and differs from other PRs
- What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
- Removed code smells/wrote code to be clearer
- Added sections to issue and PR templates for doc changes
Collaborator
Author
|
@omnidan These are just a few minor changes. I think I'm going to work on field extensions next (you can look at a demo in field-extensions-demo) |
nmay231
force-pushed
the
dev/spring-cleaning
branch
from
January 6, 2020 22:26
c4f3bec to
cf724cb
Compare
omnidan
suggested changes
Jan 7, 2020
| function insert (history, state, limit, group) { | ||
| debug.log('inserting', state) | ||
| debug.log('new free: ', limit - lengthWithoutFuture(history)) | ||
| debug.log('new free: ', limit - history.past.length - 1) |
Owner
There was a problem hiding this comment.
I think now it is a bit unclear why we are subtracting one. Either we store this in a separate variable (history.path.length + 1), or we keep the function
nmay231
force-pushed
the
dev/spring-cleaning
branch
from
January 7, 2020 17:21
cf724cb to
beb4b55
Compare
Collaborator
Author
|
Changes made 👍 I already rebased it manually, so this can be merged normally. Thanks. |
omnidan
approved these changes
Jan 8, 2020
Owner
|
Thanks @nmay231 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.