[Bug fix] Fix order of nms score_factor #4473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4473 +/- ##
==========================================
+ Coverage 61.93% 62.00% +0.06%
==========================================
Files 241 241
Lines 18357 18359 +2
Branches 3075 3075
==========================================
+ Hits 11369 11383 +14
+ Misses 6430 6418 -12
Partials 558 558
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ZwwWayne
reviewed
Jan 19, 2021
Collaborator
|
Kindly ping @RunningLeon, does the modification affect the ONNX exportation? |
ZwwWayne
approved these changes
Jan 24, 2021
Collaborator
|
@ZwwWayne No bad impacts with PyTorch2ONNX. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #4322
Before #4087,
score_thris applied before multiplyscore_factor.However, in #4087, the order is switched, which led to the degenerated performance for YOLOv3 and FCOS.