Skip to content

[Doc] Polish RTMO homepage - #2870

Merged
Tau-J merged 4 commits into
open-mmlab:dev-1.xfrom
Ben-Louis:support-rtmo
Dec 16, 2023
Merged

Tau-J merged 4 commits into
open-mmlab:dev-1.xfrom
Ben-Louis:support-rtmo

Conversation

@Ben-Louis

Copy link
Copy Markdown
Collaborator

Motivation

Modification

  1. polish RTMO homepage
  2. fix several bugs in training. The original implementation in tools/slurm_train.sh and tools/slurm_test.sh do not properly support multiple Python arguments. All Python arguments are treated as a single string. Having more than one argument will result in errors.

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@Ben-Louis
Ben-Louis requested a review from Tau-J December 15, 2023 12:12
@codecov

codecov Bot commented Dec 16, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1beeb6c) 71.80% compared to head (e3663dc) 71.82%.

Files Patch % Lines
...asets/datasets/wholebody/coco_wholebody_dataset.py 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2870      +/-   ##
===========================================
+ Coverage    71.80%   71.82%   +0.01%     
===========================================
  Files          292      292              
  Lines        19934    19938       +4     
  Branches      3369     3370       +1     
===========================================
+ Hits         14314    14320       +6     
  Misses        4813     4813              
+ Partials       807      805       -2     
Flag Coverage Δ
unittests 71.82% <40.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tau-J
Tau-J merged commit fcb88da into open-mmlab:dev-1.x Dec 16, 2023
Ben-Louis added a commit to Ben-Louis/mmpose that referenced this pull request Dec 22, 2023
Ben-Louis added a commit to Ben-Louis/mmpose that referenced this pull request Dec 22, 2023
SugarBlend pushed a commit to SugarBlend/mmpose that referenced this pull request Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants