Skip to content

[Fix] fix RTMPose app - #2880

Merged
Tau-J merged 3 commits into
open-mmlab:dev-1.xfrom
Ben-Louis:add-rtmpose-app
Dec 20, 2023
Merged

[Fix] fix RTMPose app#2880
Tau-J merged 3 commits into
open-mmlab:dev-1.xfrom
Ben-Louis:add-rtmpose-app

Conversation

@Ben-Louis

@Ben-Louis Ben-Louis commented Dec 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Motivation

Modification

The modified app.py has been tested on OpenXLab

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov

codecov Bot commented Dec 20, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (1beeb6c) 71.80% compared to head (3ab3a24) 71.82%.
Report is 6 commits behind head on dev-1.x.

Files Patch % Lines
mmpose/models/heads/base_head.py 46.66% 6 Missing and 2 partials ⚠️
...asets/datasets/wholebody/coco_wholebody_dataset.py 25.00% 2 Missing and 1 partial ⚠️
mmpose/models/losses/classification_loss.py 75.00% 2 Missing and 1 partial ⚠️
mmpose/datasets/transforms/converting.py 0.00% 1 Missing and 1 partial ⚠️
mmpose/datasets/transforms/topdown_transforms.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           dev-1.x    #2880      +/-   ##
===========================================
+ Coverage    71.80%   71.82%   +0.02%     
===========================================
  Files          292      292              
  Lines        19934    19973      +39     
  Branches      3369     3378       +9     
===========================================
+ Hits         14314    14346      +32     
- Misses        4813     4817       +4     
- Partials       807      810       +3
Flag Coverage Δ
unittests 71.82% <64.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tau-J
Tau-J merged commit 052f388 into open-mmlab:dev-1.x Dec 20, 2023
@Ben-Louis
Ben-Louis deleted the add-rtmpose-app branch December 22, 2023 03:17
Ben-Louis added a commit to Ben-Louis/mmpose that referenced this pull request Dec 22, 2023
@Ben-Louis
[Fix] fix RTMPose app (open-mmlab#2880)
11ba630
Ben-Louis added a commit to Ben-Louis/mmpose that referenced this pull request Dec 22, 2023
@Ben-Louis
[Fix] fix RTMPose app (open-mmlab#2880)
dcf5d3e
SugarBlend pushed a commit to SugarBlend/mmpose that referenced this pull request Sep 14, 2026
@Ben-Louis
[Fix] fix RTMPose app (open-mmlab#2880)
c1032a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tau-J Tau-J Tau-J approved these changes
@xiexinch xiexinch xiexinch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ben-Louis @Tau-J @xiexinch