Skip to content

Defer Noise environment connections until registration#33166

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/83e23fa03a02e3b2bdf1a83fe26d7ac461f55cf3
Jul 14, 2026
Merged

Defer Noise environment connections until registration#33166
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/83e23fa03a02e3b2bdf1a83fe26d7ac461f55cf3

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 14, 2026

Copy link
Copy Markdown

Defer Noise environment connections until registration

What changed

  • Replace pending WebSocket URL registration with deferred Noise environment
    registration that gates connection attempts on an explicit readiness signal.
  • Reuse the Noise rendezvous transport after readiness so reconnects request a
    fresh connection bundle.
  • Preserve terminal errors for failed or dropped registrations and keep late
    completion isolated from replacement environments.

Testing

  • Add coverage for readiness gating, registration failure and replacement,
    eager Noise connections, and reconnection through a fresh rendezvous bundle.

## What changed

- Replace pending WebSocket URL registration with deferred Noise environment
  registration that gates connection attempts on an explicit readiness signal.
- Reuse the Noise rendezvous transport after readiness so reconnects request a
  fresh connection bundle.
- Preserve terminal errors for failed or dropped registrations and keep late
  completion isolated from replacement environments.

## Testing

- Add coverage for readiness gating, registration failure and replacement,
  eager Noise connections, and reconnection through a fresh rendezvous bundle.

GitOrigin-RevId: 83e23fa03a02e3b2bdf1a83fe26d7ac461f55cf3
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/83e23fa03a02e3b2bdf1a83fe26d7ac461f55cf3 branch from d0cb78d to 32cd5d4 Compare July 14, 2026 21:08
@copyberry
copyberry Bot merged commit 32cd5d4 into main Jul 14, 2026
13 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/83e23fa03a02e3b2bdf1a83fe26d7ac461f55cf3 branch July 14, 2026 21:09
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant