feat(core): add per-model-request timeouts by 2830500285 · Pull Request #1466 · openai/openai-agents-js

2830500285 · 2026-07-13T09:02:51Z

This pull request resolves #894.

It adds a provider-agnostic per-attempt deadline so one slow model request can time out and participate in runner-managed retry without cancelling the entire agent run.

Changes

Adds ModelSettings.requestTimeoutMs and ModelRequestTimeoutError for non-streaming and complete streaming attempts.
Adds retryPolicies.timeout() and normalized isTimeout facts for SDK and provider transport timeouts.
Preserves caller-abort precedence and current replay safety: emitted stream events and stateful requests without provider replay approval are not retried.
Starts best-effort cleanup of timed-out streaming iterators before retry evaluation, while preserving the timeout if provider cleanup throws, rejects, or stalls.
Prevents Responses and Hosted Multi-Agent WebSocket timeouts from replaying response.create or response.inject after send, for both runner and provider client deadlines, while keeping pre-send timeouts retryable.
Types all OpenAI WebSocket transport deadline failures with ETIMEDOUT, including deadlines already exhausted between setup steps, so retryPolicies.timeout() handles auth, connection, queue, and frame-read deadlines consistently.
Documents the lifecycle and includes patch changesets for @openai/agents-core and @openai/agents-openai.

Validation

bash .agents/skills/code-change-verification/scripts/run.sh (3,146 tests passed; 2 skipped)
pnpm -F docs build (4,637 pages)
pnpm changeset:validate-lite

changeset-bot · 2026-07-13T09:02:55Z

🦋 Changeset detected

Latest commit: 38d8249

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@openai/agents-core	Patch
@openai/agents-openai	Patch
@openai/agents-extensions	Patch
@openai/agents-realtime	Patch
@openai/agents	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 285d46bc0f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

2830500285 · 2026-07-13T09:43:44Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 51c6d9ffd6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

2830500285 · 2026-07-13T10:08:31Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d9d0c7605b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

2830500285 · 2026-07-13T10:31:04Z

@codex review

chatgpt-codex-connector · 2026-07-13T10:31:11Z

Note

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 31a0f9b84b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

2830500285 · 2026-07-13T10:41:08Z

@codex review

chatgpt-codex-connector · 2026-07-13T10:41:17Z

Note

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 47d1e6d877

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

2830500285 · 2026-07-13T10:50:55Z

@codex review

chatgpt-codex-connector · 2026-07-13T10:51:06Z

Note

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1aeb486d4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

2830500285 · 2026-07-13T11:05:48Z

@codex review

chatgpt-codex-connector · 2026-07-13T11:05:59Z

Note

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38d8249a47

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-13T11:12:38Z

        requestMayHaveReachedServer = true;
      }
      webSocket.send(frame as any);
+      markReplayUnsafe?.();


Mark queued hosted WebSocket frames unsafe for provider timeouts

When this helper is handed a hosted ResponsesWS that is still connecting, send() queues the response.create/response.inject frame and the SDK flushes that queue on socket open before the iterator yields the open message that flips requestMayHaveReachedServer. A client frame-read timeout in that small post-flush/pre-open window is now an ETIMEDOUT error matched by retryPolicies.timeout()/networkError(), but the catch path will not set unsafeToReplay, so the hosted turn can be replayed after the first frame already left the socket. Please mark provider errors unsafe once a frame has been queued/sent, or otherwise distinguish definitely-unsent queued frames.

Useful? React with 👍 / 👎.

kalyanamdewri

Non-blocking cancellation test on `38d8249a4751d2e51c94e94499c69c3dacf77191`

Environment: macOS 26.1 (25B78), arm64, Node v22.14.0, pnpm 11.10.0; base 901fb94c0fb9ffc8cb2d8275d99622475f77f401; seed none-deterministic-v1 (no randomness).

I injected the deadline after stream event 3 (third response.function_call_arguments.delta), with partial tool arguments 17/35 received.

Branch	Caller result	Completion latency	Producer tasks after `2000` ms	Abort listeners after settle
base	`resolved (cancelled=true), 3/3`	`2.079 ms median (1.904–2.185 ms)`	`0`	`0`
PR	`resolved (cancelled=true), 3/3`	`2.149 ms median (2.044–2.170 ms)`	`0`	`0`

The measured invariant was Cancellation must propagate to the producer and converge to the baseline live-task/resource count. It HELD because all 3/3 runs on both branches observed the provider abort, finalized the producer, and returned from one active producer task to baseline 0 with 0 visible abort listeners after 2000 ms; the PR also cleared its one 30000 ms request timer, leaving 0 timers.

Trace and minimized fixture: /tmp/cancellation-test/slot2-cancellation-artifact.tar.gz (sha256:5a863f8d23c94d88a8484ecd0e3bf604c43797816423cc36840f5a293076d99e). I did not test a real network socket, a non-cooperative provider, or expiry into ModelRequestTimeoutError. Producer tasks are the fixture model’s exact active-task count, not all SDK/Node Promise tasks; listener counts cover direct JavaScript listeners on retained signals, while native AbortSignal.any parent links are not exposed.

feat(core): add per-model-request timeouts

285d46b

github-actions Bot added documentation Improvements or additions to documentation package:agents-core labels Jul 13, 2026

chatgpt-codex-connector Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread packages/agents-core/src/runner/modelRetry.ts

fix(openai): preserve websocket timeout replay safety

51c6d9f

github-actions Bot added package:agents-openai project labels Jul 13, 2026

chatgpt-codex-connector Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread packages/agents-core/src/runner/modelRetry.ts

Comment thread packages/agents-core/src/runner/modelRetry.ts

fix(openai): harden websocket timeout retries

d9d0c76

chatgpt-codex-connector Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread packages/agents-core/src/runner/modelRetry.ts

fix(openai): type expired websocket deadlines

31a0f9b

chatgpt-codex-connector Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread packages/agents-openai/src/openaiResponsesModel.ts

fix(openai): veto post-send websocket retries

47d1e6d

chatgpt-codex-connector Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread packages/agents-core/src/runner/modelRetry.ts Outdated

fix(core): close timed-out stream iterators

a1aeb48

chatgpt-codex-connector Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread packages/agents-core/src/runner/modelRetry.ts Outdated

fix(core): preserve streaming timeout failures

38d8249

chatgpt-codex-connector Bot reviewed Jul 13, 2026

View reviewed changes

kalyanamdewri reviewed Jul 14, 2026

View reviewed changes

Uh oh!

Conversation

2830500285 commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Validation

Uh oh!

changeset-bot Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

2830500285 commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

2830500285 commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

2830500285 commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

2830500285 commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

2830500285 commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

2830500285 commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

kalyanamdewri left a comment

Choose a reason for hiding this comment

Non-blocking cancellation test on 38d8249a4751d2e51c94e94499c69c3dacf77191

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2830500285 commented Jul 13, 2026 •

edited

Loading

changeset-bot Bot commented Jul 13, 2026 •

edited

Loading

Non-blocking cancellation test on `38d8249a4751d2e51c94e94499c69c3dacf77191`